-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library broken again. #57
Comments
I am again going to have to fork this project just to get Laravel Forge back online. Please please please fix how you are detecting these properties. If DigitalOcean adds a new one your library breaks EVERY time. |
Totally agree with Taylor. A simply change in property now makes the library and any package depending on yours unusable. |
This library isn't meant for production yet since the api is still in beta and changes often. i will update the library to add any missing fields. |
@taylorotwell the point of the exception we are throwing is that we can determine the changes since they are not always documented in the change log : https://developers.digitalocean.com/changelog/ |
You should also check my screenshot. Size has been renamed sizeSlug. |
Renaming size to sizeSlug property will give you obsolete lines 151-153 (https://github.com/toin0u/DigitalOceanV2/blob/babb533d8ab48265c3cdac4f6e48f36fe9f569d6/src/Entity/Droplet.php#L151). Renaming those lines as well will cause a new exception, so that's no option. |
@luceos You are absolutely right! those lines are obsolete. there is no point of catching the sizeSlug property because it is handled automatically. i will remove them. thank you! |
http://d.pr/i/1cv7Y/2yg6q7un
The way you are detecting these properties is extremely brittle and is breaking vital production projects.
The text was updated successfully, but these errors were encountered: