Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: broken functionality for strings containing diacritics #56

Closed
dangeol opened this issue Feb 15, 2020 · 0 comments · Fixed by #57
Closed

Search: broken functionality for strings containing diacritics #56

dangeol opened this issue Feb 15, 2020 · 0 comments · Fixed by #57
Assignees
@smkvr98

Comments

@dangeol
Copy link
Collaborator

dangeol commented Feb 15, 2020 •
edited by parthopdas

The letters with diacritical marks are converted into a UTF-8 hex format, causing troubles. This bug must have been introduced recently.
Using commit #408039f from three weeks ago, this bug was not yet there.

Ensure the following cases work before closing this issue:

  • karaṇīya
  • kara.niiya
  • dāna

This screenshot shows the problem for the search string dāna.
2020-02-16 14_17_01-Search_ 'd%C4%81na' in Multiple Sets
@dangeol dangeol self-assigned this Feb 15, 2020
@dangeol dangeol mentioned this issue Feb 15, 2020
Merged
@parthopdas parthopdas reopened this Feb 17, 2020
@parthopdas parthopdas changed the title Search: Make RegEx search work Search: RegEx searches aren't working. I tested with āmi\b which should list hundreds of results, but nothing. Feb 17, 2020
@parthopdas parthopdas changed the title Search: RegEx searches aren't working. I tested with āmi\b which should list hundreds of results, but nothing. Search: broken functionality for strings containing diacritics Feb 17, 2020
@parthopdas parthopdas mentioned this issue Feb 17, 2020
Closed
@parthopdas parthopdas assigned smkvr98 and unassigned dangeol Feb 17, 2020
@dangeol dangeol mentioned this issue Feb 22, 2020
Closed
@smkvr98 smkvr98 mentioned this issue Feb 24, 2020
Merged
@dangeol dangeol closed this as completed Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smkvr98 smkvr98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(search) make regex work
3 participants
@parthopdas @dangeol @smkvr98