feat: add skipType option #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
juliuscc
reviewed
Nov 15, 2022
The rest of the failing tests now just match the existing behaviour, they were either wrong or looked things looked fine as they were.
juliuscc
reviewed
Dec 9, 2022
|
Could you please remove I do think it's good that it gets updated to the new lockfile format but it also seems like a typical way to include a malicious package. I think it might be a good idea to do it in a separate PR. 😁 |
|
Except for my two comments I think it looks great 😁 👍 |
Co-authored-by: Julius Recep Colliander Celik <julius.cc@hotmail.com>
s-hoff
force-pushed
the
feat/skip-type
branch
from
a5c5fee
to
0f980fc
Compare
|
Oh, I must have somehow missed that lockfile being in there. I rolled that one back. |
juliuscc
approved these changes
Dec 12, 2022
|
Great work! Thanks for the PR ❤️ |
|
🎉 This PR is included in version 7.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, the skipped type still appears as
undefined. I'll look back into finishing this once I get the time again.closes #74