-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review break out properties in typings #80
Comments
I can't repro this failure. I just ran a simple model through ParseToJson() on the latest preview package (1.0.35-preview-gf7d12847e2) and its output included:
|
should the new breakout properties reference the concrete interfaces? from export interface InterfaceInfo extends EntityInfo {
EntityKind: 'Interface';
contents: { [name: string]: string };
commands: { [name: string]: string };
components: { [name: string]: string };
properties: { [name: string]: string };
relationships: { [name: string]: string };
telemetries: { [name: string]: string };
extends: string[];
extendedBy: string[];
schemas: string[];
} to export interface InterfaceInfo extends EntityInfo {
EntityKind: 'Interface';
contents: { [name: string]: ContentInfo };
commands: { [name: string]: CommandInfo };
components: { [name: string]: ComponentInfo };
properties: { [name: string]: PropertyInfo };
relationships: { [name: string]: RelationshipInfo };
telemetries: { [name: string]: TelemetryInfo };
extends: string[];
extendedBy: string[];
schemas: string[];
} |
The DtdlOm.d.ts file describes the JSON returned by ParseToJson(), which does not return a hierarchical structure. The JSON object that is the value of, e.g., "components" maps name strings to DTMI strings, not to ComponentInfo JSON objects. This is the same for the breakout properties as it is/was for the "contents" property. |
got it. I'm leaving this issue open until the JS sample is updated to reflect those properties (that will require to populate to full objects) |
These properties are not available in the output of
ParseToJson
DTDLParser/javascript/generated/DtdlOm.d.ts
Lines 145 to 152 in f7d1284
Need to figure out how to consume those types in the JS Sample
The text was updated successfully, but these errors were encountered: