Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Upload image feature doesn't work on dashboard #911

Open
2 of 3 tasks
pranshugupta54 opened this issue May 17, 2024 · 16 comments
Open
2 of 3 tasks

[Bug]: Upload image feature doesn't work on dashboard #911

pranshugupta54 opened this issue May 17, 2024 · 16 comments
Assignees
Labels
bug Something isn't working gssoc

Comments

@pranshugupta54
Copy link
Member

Contact Details

No response

What happened?

Upload functionality was there before re-designing the dashboard - maybe it's commented and needs to be added back

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Are you interested in contributing?

  • I'd like to work on this issue

Code of Conduct

  • I have used the search function to check if an issue already exists
  • I agree to follow this project's Code of Conduct

Which program are you contributing in?

gssoc

@pranshugupta54 pranshugupta54 added the bug Something isn't working label May 17, 2024
Copy link

linear bot commented May 17, 2024

Copy link

Hello @pranshugupta54! 🌟
Thanks a bunch for creating an issue. Your input is invaluable, and we're eager to collaborate with you to address the matter. Keep up the fantastic work!

Don't forget to hit the ⭐ star button 😉

Tip

Don't forget to check our Contributing Guidelines, PR Guidelines and Issue Guidelines for more details.

Website | Discord | Twitter | Instagram | Linkedin

@github-actions github-actions bot added the gssoc label May 17, 2024
@saadman-galib
Copy link
Contributor

I am interested to work on this issue.
Are you talking about this upload button under profile image?
image

@pranshugupta54
Copy link
Member Author

Yes

@saadman-galib
Copy link
Contributor

@pranshugupta54 After selecting the image from file explorer should i direct upload to backend or show modal to confirm.

@pranshugupta54
Copy link
Member Author

Gonna be better if we show a modal (No option to make changes like zoom or crop but just a confirmation)

@saadman-galib
Copy link
Contributor

@pranshugupta54
Is the ui okay? I have grabbed the same ui from ratings page
Screenshot_2024-05-28_15-24-21

@pranshugupta54
Copy link
Member Author

Looks good

@saadman-galib
Copy link
Contributor

saadman-galib commented May 31, 2024

@pranshugupta54 Will I add a manual refresh on the page? Because the profile image is not updated but not showing.

@pranshugupta54
Copy link
Member Author

Yes you can refresh it or update the state of the image

@saadman-galib
Copy link
Contributor

Got a new bug under this issue.
on click save changes button, it is now showing two popups. where it should show only one.

2024-06-03.08-00-43.mp4

@pranshugupta54
Copy link
Member Author

The modal and Save button on bottom of the page can use separate functions

@saadman-galib
Copy link
Contributor

The modal and Save button on bottom of the page can use separate functions

Okay

@saadman-galib
Copy link
Contributor

saadman-galib commented Jun 3, 2024

@pranshugupta54 the image update problem for the dashboard is fixed but on the navbar, it is still not fixed. Do you have any idea how to fix this?
The image is updated on Firebase but not showing on the dashboard just after updating on Firebase. But it updates the user image after fetching the auth after some time or while visiting any other page
image
image
image

@pranshugupta54
Copy link
Member Author

You probably need to make some changes to user context or check how navbar works - check which image does it use and is that being updated? If nothing works then just refresh the page on image update.

@saadman-galib
Copy link
Contributor

@pranshugupta54 I have added a refresh because i could not find how to bind image src with userauthcontext. Pls have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc
Projects
None yet
Development

No branches or pull requests

2 participants