Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hyphen ("-") in group names #19

Closed
sharkister opened this issue Jun 6, 2021 · 1 comment
Closed

Support hyphen ("-") in group names #19

sharkister opened this issue Jun 6, 2021 · 1 comment

Comments

@sharkister
Copy link

sharkister commented Jun 6, 2021

Currently group name that containes hyphens are handled incorrect:

Example:
a user has memberOf=CN=DE-APP-ACCESS,OU=Access,OU=Application,OU=Groups,OU=Client,OU=DE,DE=example,DC=com
--> Group name is handled as "DE" instead of "DE-APP-ACCESS".

It seems, that the regex in aldap.py / __find__match didn't include "-"
Should be
adGroup = re.match('CN=((\w*\s?_?-?]*)*)', adGroup).group(1)
instead of
adGroup = re.match('CN=((\w*\s?_?]*)*)', adGroup).group(1)

@dignajar
Copy link
Owner

dignajar commented Jun 7, 2021

FIxed in version 2.0.2. Thank you for report the issue.

@dignajar dignajar closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants