Skip to content
This repository has been archived by the owner on Oct 18, 2018. It is now read-only.

Author name on home and post is not shown properly on Skeleton #20

Closed
AbrahamAriel opened this issue Jan 15, 2016 · 1 comment
Closed

Comments

@AbrahamAriel
Copy link
Contributor

The code is done to make sure that it shows the name(s) if available, else revert to the username. However it was done wrong. It keeps using the username regardless.

To fix this, change && to || in this line:
if( Text::isNotEmpty($Post->authorFirstName()) && Text::isNotEmpty($Post->authorLastName()) )

Fixed:
if( Text::isNotEmpty($Post->authorFirstName()) || Text::isNotEmpty($Post->authorLastName()) )

@AbrahamAriel AbrahamAriel changed the title Poster name on home and post is not shown properly Author name on home and post is not shown properly on Skeleton Jan 16, 2016
@dignajar
Copy link
Owner

authorFirstName and authorLastName are depreacted. Sorry for my late answer, I recently update the themes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants