Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect root does not cause test failures #60

Closed
JamesLongman opened this issue Nov 1, 2018 · 2 comments
Closed

Incorrect root does not cause test failures #60

JamesLongman opened this issue Nov 1, 2018 · 2 comments
Assignees
Labels
Bug Something isn't working In Progress Issue is assigned and in progress

Comments

@JamesLongman
Copy link
Contributor

test/project-files.js and /test/src/assets/pictures/picture-assets.js tests should fail without a correct root but don't

These tests certainly used to work and as far as I know they haven't been changed since they did so I'm not sure why they're not working.

@JamesLongman JamesLongman added Bug Something isn't working Status: Awaiting Assignment labels Nov 1, 2018
@microwavekonijn microwavekonijn moved this from To do to In progress in Achieve v1 Stable Release Nov 12, 2018
@microwavekonijn microwavekonijn self-assigned this Nov 12, 2018
@microwavekonijn microwavekonijn added In Progress Issue is assigned and in progress and removed Status: Awaiting Assignment labels Nov 12, 2018
@microwavekonijn
Copy link
Collaborator

The reason why the test doesn't work is because existsSync doesn't throw an error, it will return boolean depending on whether the files exists. I assume before the existsSync function was used an other method was used where it tries to read the file and throws and error when it doesn't exist.

@JamesLongman
Copy link
Contributor Author

Yeah, I think I recall it being updated as we used a previous method which node depreciated previously. I guess when we changed the method we didn't change the tests to booleans rather than catching errors, which quite frankly is an improvement

@microwavekonijn microwavekonijn moved this from In progress to Issue Closed in Achieve v1 Stable Release Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working In Progress Issue is assigned and in progress
Projects
No open projects
Achieve v1 Stable Release
  
Issue Closed
Development

No branches or pull requests

2 participants