Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update favicons-webpack-plugin dependency #32

Closed
peacememories opened this issue Jan 3, 2020 · 3 comments
Closed

Update favicons-webpack-plugin dependency #32

peacememories opened this issue Jan 3, 2020 · 3 comments
Projects

Comments

@peacememories
Copy link

Currently I am not able to use elm-pages on macos with node 13, because the version of favicons-webpack-plugin it depends on in turn depends on sharp v0.22.1. The first version supporting node 13 is v0.23.2, which is depended on by the current version of favicons-webpack-plugin, so a dependency update should fix this.

@dillonkearns dillonkearns added this to To prioritize in Roadmap Jan 4, 2020
@dillonkearns
Copy link
Owner

Hey, thanks for the suggestion and context. I looked at this a while back but it wasn't out yet, or there was something blocking it. I had to use a beta version to get version 4 of the html-webpack-plugin, but it seems to work fine. Here's the commit: 31f23a5. And here's the changelog entry.

Let me know how it goes with using this with Node 13!

@dillonkearns dillonkearns moved this from To prioritize to Released in Roadmap Jan 4, 2020
@peacememories
Copy link
Author

Thanks for the quick fix! The install now runs without a problem.

@dillonkearns
Copy link
Owner

Fantastic, thank you so much for reporting back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Roadmap
  
Released
Development

No branches or pull requests

2 participants