Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klipper version tags #21

Closed
pciavald opened this issue Nov 14, 2021 · 4 comments
Closed

klipper version tags #21

pciavald opened this issue Nov 14, 2021 · 4 comments

Comments

@pciavald
Copy link

pciavald commented Nov 14, 2021

Hi,

Would it be possible to include klipper's version (and possibly moonraker) in the klipper-moonraker image's tags corresponding to the klipper repo's tags for the builds that are not just daily builds of the master branch?

That would be convenient to be able to follow the main releases.

for instance:

# both on last tag
klipper-moonraker:0.10.0-0.7.1
# alias
klipper-moonraker:last-stable
# klipper from main branch, moonraker tag
klipper-moonraker:20211031-0.7.1
# daily build on a non-tag day
klipper-moonraker:20211031

Thank you!

@dimalo
Copy link
Owner

dimalo commented Nov 15, 2021

great idea! will look into it, if you have any suggestions, I'd like to hear them :)

@pciavald
Copy link
Author

To avoid doing it manually, it seems there's a way to trigger github actions from another repo if you get collaboration from the remotes : https://github.community/t/triggering-by-other-repository/16163 and you could then get the tag name with something like this : https://github.community/t/how-to-get-just-the-tag-name/16241

@pciavald
Copy link
Author

If that can be of interest, currently i'm using a modified version of your docker images that clones like:

ENV VERSION v0.10.0
RUN git clone \
  --depth 1 \
  --branch ${VERSION} \
  https://github.com/Klipper3d/klipper

@dimalo
Copy link
Owner

dimalo commented Jan 18, 2022

@dimalo dimalo closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants