Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/chore #108

Merged
merged 2 commits into from Aug 15, 2019
Merged

Fix/chore #108

merged 2 commits into from Aug 15, 2019

Conversation

SunriseFox
Copy link
Contributor

This PR solves the following issues:

  • html-webpack-plugin inject unnecessary chunks into index.html (which prevents popup from being loaded)
  • throws on [undefined] when no identity is found.

Jack-Works
Jack-Works requested changes Aug 15, 2019
View reviewed changes
src/components/Welcomes/1a1a.tsx Outdated Show resolved Hide resolved
config-overrides.js Show resolved Hide resolved
@Jack-Works Jack-Works self-requested a review August 15, 2019 14:41
@Jack-Works Jack-Works merged commit c418aea into master Aug 15, 2019
@Jack-Works Jack-Works deleted the fix/chore branch August 15, 2019 14:44
lucasespinosa28 pushed a commit to lucasespinosa28/Maskbook that referenced this pull request Dec 13, 2021
@austintgriffith
Merge pull request DimensionDev#108 from Xalava/master
1745776 
adding mumbai testnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-Works Jack-Works Jack-Works approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SunriseFox @Jack-Works