Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on dimfeld/httppath #39

Closed
bastiankoetsier opened this issue Dec 19, 2016 · 2 comments
Closed

Dependency on dimfeld/httppath #39

bastiankoetsier opened this issue Dec 19, 2016 · 2 comments

Comments

@bastiankoetsier
Copy link
Contributor

When tinkering with your router, I found that it depends on github.com/dimfeld/httppathwhich is not declared. Do you want a PR for including this dependency directly in the router(because it is only one func) or just one for adding this to the readme ?

Thanks.

@bastiankoetsier bastiankoetsier changed the title Dependency on github.com/dimfeld/httppath Dependency on dimfeld/httppath Dec 19, 2016
@dimfeld
Copy link
Owner

dimfeld commented Dec 20, 2016

Yeah, just adding the function directly to this package is fine with me. I've been meaning to do that for a while, and just never got around to it.

@bastiankoetsier
Copy link
Contributor Author

Cool! I will make a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants