Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests should use httptest for request creation #60

Closed
Backfighter opened this issue Feb 6, 2018 · 1 comment
Closed

Tests should use httptest for request creation #60

Backfighter opened this issue Feb 6, 2018 · 1 comment

Comments

@Backfighter
Copy link

Backfighter commented Feb 6, 2018 •
edited
Loading

The test should use httptest.NewRequest instead of creating request manually using http.NewRequest.
@dimfeld
Copy link
Owner

dimfeld commented Feb 6, 2018

I'm going to leave this one the way it is in favor of backwards compatibility with older versions of Go, but thanks for filing the issue.

@dimfeld dimfeld closed this as completed Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dimfeld @Backfighter