Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netlify.toml #13

Closed
liester opened this issue Oct 5, 2019 · 1 comment
Closed

netlify.toml #13

liester opened this issue Oct 5, 2019 · 1 comment
Labels
type: bug Something isn't working

Comments

@liester
Copy link
Contributor

liester commented Oct 5, 2019

Describe the bug

Using yarn create social-network my-network creates a netlify.toml with a publish = "frontend/build". Following the frontend deployment guide to netlify results in the netlify.toml overriding the build settings, which is desired. Unfortunately, it leads to this netlify error.
failed during stage 'building site': Deploy directory 'frontend/frontend/build' does not exist
Updating the netlify.toml to have a base = "frontend" and `publish="build"`` resolves the issue on netlify.

System

Node.js version: 11.11.0
NPM or Yarn version: Yarn 1.15.2
Operating system: Windows 10

Steps to reproduce
(Write your steps here:)

  1. yarn create social-network my-network
  2. push the entire repo to github
  3. link github repo to netlify
  4. deploy master branch of github repo via netlify

Expected behavior

React frontend is available after netlify deploy steps completed.

Actual behavior

Netlify fails to deploy the react application based on the netlify.toml
image

Reproducible demo

https://github.com/liester/test-social-network

Additional context

I have created a PR for the netlify.toml modification.

@liester liester added the type: bug Something isn't working label Oct 5, 2019
@DimiMikadze
Copy link
Owner

Hi @liester thanks for reporting the issue and PR for fixing it! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants