Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minProportion #6

Closed
jeffreyhanson opened this issue Dec 1, 2021 · 4 comments
Closed

minProportion #6

jeffreyhanson opened this issue Dec 1, 2021 · 4 comments
Labels
question Further information is requested

Comments

@jeffreyhanson
Copy link
Collaborator

jeffreyhanson commented Dec 1, 2021 •
edited
Loading

This issue is similar to #5 - should the minProportion parameter be considered mandatory or optinal? If mandatory, where should it be specified? If optional, should we just set a default value of 1 if the user doesn't specify a value?
@jeffreyhanson jeffreyhanson added the question Further information is requested label Dec 1, 2021
@dimitri-justeau
Copy link
Owner

I never thought about that but it would make total sense to set it at 1 by default!

@jeffreyhanson
Copy link
Collaborator Author

Ok - awesome! So, let's we'll add a custom constraint function to specify the minProportion value?

@dimitri-justeau
Copy link
Owner

dimitri-justeau commented Dec 7, 2021 •
edited
Loading

I'd rather have juste one add_restorable_constraint with minProportion as an optional argument, as this parameter is not really a constraint in itself.

@jeffreyhanson
Copy link
Collaborator Author

Sounds good - I'll close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dimitri-justeau @jeffreyhanson