Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong install PATHs #40

Closed
Thanatermesis opened this issue Oct 15, 2023 · 6 comments
Closed

Wrong install PATHs #40

Thanatermesis opened this issue Oct 15, 2023 · 6 comments
Assignees

Comments

@Thanatermesis
Copy link
Contributor

Thanatermesis commented Oct 15, 2023

This is a minor bug report, something changed since the version 20230318 (commit d557d5e #d557d5e7 ) where some files are installed in a different / strange path, I fixed it manually in my package build but I think should be fixed on upstream, these are the details of my overwritten locations:

/usr/local/share/applications   /usr/share/applications
/usr/local/share/icons          /usr/share/icons
/usr/share/eflete/AUTHORS       /usr/share/doc/eflete/AUTHORS

@dimmus
Copy link
Owner

dimmus commented Oct 16, 2023

It seems okay. Your system build tool prefix is /usr. Mine is /usr/local (check the readme file).
What errors did you get? I will check the work of dir_prefix in meson.

Is the last one working? Check out the About page. Eflete uses AUTHORS to populate About page.

@dimmus dimmus self-assigned this Oct 16, 2023
@Thanatermesis
Copy link
Contributor Author

Is not an error, everything installs correctly, they are just installed in a wrong directory so as the previous example I just moved manually the files in the package to be in the correct location, yes the prefix is /usr here in the package and so I think that is important because applications and icons should be then in the /usr (not in /usr/local), again its not a problem for me but I wanted to report it because maybe the prefix is wrongly read on the makefiles or something similar?

@dimmus
Copy link
Owner

dimmus commented Oct 25, 2023

For me:
/usr/bin : contains executable programs that are part of the operating system and installed by its package manager
/usr/local/bin : default location for executable programs not part of the operating system and installed there by the local administrator, usually after building them from source

The same for applications, icons, etc

@dimmus dimmus closed this as completed Oct 25, 2023
@Thanatermesis
Copy link
Contributor Author

Sorry I didn't see the last comment.

Yes exactly, for me too. The problem is that eflete is built using --prefix=/usr , that's why I said they are put in the wrong place (/usr/local/)

I think you can try this easily with something like this:

./configure --prefix=/usr
make
mkdir tmpinstalldir
make DESTDIR=tmpinstalldir install
tree tmpinstalldir

probably with the previous step, you can see inside the dir "tmpinstalldir" everything installed in a /usr structure, but some files are put on tmpinstalldir/usr/local. Probably if you do --prefix=/opt they are put on tmpinstalldir/usr/local too 🤔

@dimmus
Copy link
Owner

dimmus commented Oct 25, 2023

Ok, I get it. You say, that Eflete doesn't follow a prefix. I definitely should check this out. Thanks.

@dimmus dimmus reopened this Oct 25, 2023
@dimmus
Copy link
Owner

dimmus commented Oct 26, 2023

Found hardcoded paths. Solved in 411dc54.
Thanks

@dimmus dimmus closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants