Returning all records results in 200+ queries

[turtlechase]

Hi,

Country::listsTranslations('name')->pluck('name', 'id')->toArray();

I'm doing this to get all my countries translated.

It does 200+ queries. Does a query per country to get it's name.

It runs this query:

SELECT
  `countries`.`id`,
  `country_translations`.`name`
FROM `countries`
  LEFT JOIN `country_translations` ON `country_translations`.`country_id` = `countries`.`id`
WHERE (
  `country_translations`.`locale` = 'pt' 
  OR (
    `country_translations`.`locale` = 'pt' 
    AND `country_translations`.`country_id` NOT IN (
      SELECT `country_translations`.`country_id`
      FROM `country_translations`
      WHERE `country_translations`.`locale` = 'pt'
    )
  )
);

But then runs the same query

SELECT *
FROM  `country_translations`
WHERE `country_translations`.`country_id` IS NULL 
  AND `country_translations`.`country_id` IS NOT NULL;

one for each country.

What am I doing wrong?

Thanks

[Gummibeer]

This is related to #482 - I bet that the problem is that your toArray() call ends in the attributesToArray() which says that translations relation is not loaded but he should do it on toArray - so he loads it. Super bad in your case.
Ideas to solve this are in the linked issue.

As a workaround you could do ->load('translations'). This will load all translations in a single query. If you don't want to load translations on toArray() call in general you can also disable this in the config file.

But I will think about a solution to get around this.

[Gummibeer]

I've added a fix in #484 - can you take a look if it solves your problem?