Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "title" attrib to the popup image #1159

Open
geeday opened this issue Oct 23, 2020 · 1 comment
Open

Adding "title" attrib to the popup image #1159

geeday opened this issue Oct 23, 2020 · 1 comment

Comments

@geeday
Copy link

geeday commented Oct 23, 2020

within src/js/image.js
we have
img.alt = item.el.find('img').attr('alt');

which passes the "alt" attrib of the base image to the main popup.
can we add:
img.title = item.el.find('img').attr('title');
below that line of code which will add the "title" attrib.

I'd do it myself, but not got the build stuff installed

I guess "git clone"
git add
git commit
git push
(etc)
on untested code is bad

thanks

@ixaxi
Copy link

ixaxi commented Apr 15, 2021

yes you can :) It will then show the title when the mouse hovers over the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants