Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADA Empty button Flag #1503

Open
swmcgithub opened this issue Mar 21, 2018 · 0 comments
Open

ADA Empty button Flag #1503

swmcgithub opened this issue Mar 21, 2018 · 0 comments

Comments

@swmcgithub
Copy link

Hello,

I'm working on making sure my site passes ADA compliance and I'm getting an Empty Button error on some of the code generated by your plugin.
<button class="pswp__button pswp__button--close" title="Close (Esc)"></button> <button class="pswp__button pswp__button--share" title="Share"></button> <button class="pswp__button pswp__button--fs" title="Toggle fullscreen"></button> <button class="pswp__button pswp__button--zoom" title="Zoom in/out"></button>
These lines of code are causing an issue with our web accessibility evaluation tool. We can go in and add the appropriate aria-labels to these buttons, but I'm concerned that any future updates will overwrite our changes. Are there any other options we can do to help resolve this issue?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant