Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5-Beta why did loading css using module got removed? #1800

Closed
picarica opened this issue Aug 3, 2021 · 2 comments
Closed

V5-Beta why did loading css using module got removed? #1800

picarica opened this issue Aug 3, 2021 · 2 comments

Comments

@picarica
Copy link

picarica commented Aug 3, 2021

so i updated to newest version of photoswipe i was at 5.0.3 version before and my gallery stoppe working chceckout out changes and it seems that loading css and .js files were removed, why is that ? i dont see docs updated it was just remvoed from source code

so now we have to manually load css and .js ? for it to work ?

@dimsemenov
Copy link
Owner

It added unnecessary complexity - browsers don't have a simple API to load CSS dynamically. And the performance impact of CSS file is much less than JS. So it was removed in 5.1.

The documentation should be updated, if you find some page where it isn't - please let me know.

Apologies for the inconvenience, but this might happen during the beta.

@picarica
Copy link
Author

It added unnecessary complexity - browsers don't have a simple API to load CSS dynamically. And the performance impact of CSS file is much less than JS. So it was removed in 5.1.

The documentation should be updated, if you find some page where it isn't - please let me know.

Apologies for the inconvenience, but this might happen during the beta.

thanks for answering i was just curious why the feature was removed, so thank you for explanation
i just looked here #1749 and saw linking ot css in main post is still present and thats where i came from, but i just noticed it's been updated also in the new test demo page so that's it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants