Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features: Fit window height/width, Original size, Zoom on mouse scroll #950

Closed
ghost opened this issue Aug 29, 2015 · 3 comments
Closed

Comments

@ghost
Copy link

ghost commented Aug 29, 2015

Is it possible to add the following features?

  • Zoom with mouse wheel (important)
  • Display image in original size (important)
  • Fit window height/width (not important)

To not break the compatibility with current users, these features can be disabled by default.


Currently I use this plugin to display and inspect screenshots made with this extension.
I really like the PhotoSwipe's design and how it works on mobile, and I wan't to switch to it.

@mjau-mjau
Copy link

Sorry I can't answer about mouse-wheel, but "display image in original size" is already available for the visitor when they click the "zoom" button.

"Fit window height/width" - Do you mean having an option to fit the image by width or height, instead of how it is now with the image fit by width and height? If one was to add such an option, depending on image aspect vs screen aspect, it would often mean parts of the image would be hidden.

Why bother having such buttons when the image can be zoomed and panned anyway? I don't see what it would be used for ...

@ghost
Copy link
Author

ghost commented Sep 4, 2015

but "display image in original size" is already available for the visitor when they click the "zoom" button.

I thought it is just zoomed a little. But if the zoom means original size, then its very good 👍

it would often mean parts of the image would be hidden

Ok, then ignore the Fit feature.


Thank you

@ghost ghost closed this as completed Sep 4, 2015
@nunowar
Copy link

nunowar commented Jan 17, 2019

Some tips to implement maxZoom to fit window height/width?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants