Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request/suggestion #99

Closed
Hk1020 opened this issue Aug 31, 2011 · 23 comments
Closed

Feature request/suggestion #99

Hk1020 opened this issue Aug 31, 2011 · 23 comments

Comments

@Hk1020
Copy link

Hk1020 commented Aug 31, 2011

Safari on iPad has the feature that if you tap and hold an image you can save it. This seems to work only if you do that to an img element (though I haven't thoroughly checked that). In the photoswipe image gallery this doesn't work as you are hovering over something else apparently. Would it be possible to modify photoswipe accordingly? Would be really cool if you could save images that way.

@codecomputerlove
Copy link
Contributor

Possibly I'll look into it. PhotoSwipe needs to override the default touch events to work effectively which is preventing the default "save as" dialog

@hndcrftd
Copy link

hndcrftd commented Feb 6, 2012

It's February, 2012 and it seems this feature hasn't made it in as of yet. Any feedback on the matter would be appreciated.
It's a great piece of software for the mobile (thank you very much!), and would be even better with the save option on mobile phones

@Jisay
Copy link

Jisay commented Jan 7, 2013

+1 Should be nice to have the possibility of the "Save As" functionnality

@nicekiwi
Copy link

+1

2 similar comments
@J-Rabe
Copy link

J-Rabe commented Mar 29, 2014

+1

@bindiry
Copy link

bindiry commented Feb 28, 2016

+1

@exophunk
Copy link

So 5 years later, this function is still broken?

@chesio
Copy link
Contributor

chesio commented Nov 9, 2016

@exophunk It's not broken, rather not implemented. As per comments in #1216, it might be not that easy to implement.

@lost-an
Copy link

lost-an commented Nov 23, 2016

+1

1 similar comment
@bora89
Copy link

bora89 commented Dec 2, 2016

+1

@mvzen
Copy link

mvzen commented Mar 29, 2017

As per comments in #1216, it might be not that easy to implement.

Can some beer money be thrown somewhere to get this looked into?

It's a deal-breaker for me, but everything else about this plugin is perfect.

@capuski
Copy link

capuski commented Nov 9, 2017

I still miss this default long press behavior.
I did some tests again, and seems to work (Chrome on IOS [yes, i know]) just changing CSS:

body .pswp__img {
-webkit-touch-callout: default !important;
touch-callout: default !important;
-webkit-user-select: text !important;
-moz-user-select: text !important;
-ms-user-select: text !important;
}

But in Safari I can't solve this problem, sadly.

@JayWii
Copy link

JayWii commented Nov 27, 2017

@capuski I have made some modifications and encapsulation to photoswipe in the past few days , and it seems that I have fixed the problem that we can't save image through long press in safari. Maybe you can take a look , https://github.com/JayWii/Photoswipe-package

@capuski
Copy link

capuski commented Nov 27, 2017

@JayWii I tested the demo page in IOS and it worked perfectly (Safari and Chrome). I will implement it. Thank you so much!

@capuski
Copy link

capuski commented Nov 27, 2017

@JayWii have you changed a lot of the plugin? I noticed some changes in how you interact with the open photo. There is no hiding the top and bottom bars (close and caption). I consider this property very important because it allows you to view the photo in real full screen. Is there anything more significant that you have changed in the plugin?
Thanks

@JayWii
Copy link

JayWii commented Nov 28, 2017

@capuski Thanks for your feedback, i have not changed a lot of the plugin, just about long press save in Safari . About the question of 'no hiding the top and bottom bars', when you set tapToClose to false, click action will hide the top and bottom bars, btw, i add a new option topBarEl , so you can hide the top-bar without click, today i update some code, and now you can use options to use all of the plugin (Photoswipe) original options, just like this:

// JS
var options = {
    closeEl: true,
    tapToClose: false,
    topBarEl: true
}
PhotoPackage.init(imageArr, '.img-selector', options);

Vue-component is also support, you can check the readme.

@capuski
Copy link

capuski commented Nov 28, 2017

@JayWii Great. I will take a look with more attention. Thank you again :)

@capuski
Copy link

capuski commented Nov 29, 2017

@JayWii Can I use your script without changing my JS calls? My site Scripts are a little bit complex to me, lots of functions calling functions. And I use cash plugins that complicate even more.
http://nadalinfotografia.com.br/ensaio-pet-amanda-tequila/

@JayWii
Copy link

JayWii commented Nov 29, 2017

@capuski Of course, you don't have to use my plugin, you can find a script photoswipe.min.js in /build folder, and you just need use this script file to replace your old photoswipe.js or photoswipe.min.js without any change of your code

@capuski
Copy link

capuski commented Nov 29, 2017

@JayWii Strange because I just replace the photoswipe.min.js and I got error that PhotoSwipe is not defined.
captura de tela 2017-11-29 as 13 35 26

@JayWii
Copy link

JayWii commented Nov 29, 2017

@capuski sorry, it's my fault, i uploaded a wrong file and I have just reposted it correctly, you can try again. btw, I'm going to bed. Good night & Good Luck

@capuski
Copy link

capuski commented Nov 29, 2017

@JayWii Thank you so much for your help and attention. Implementing just de photoswipe.min.js causes a lot of bugs to me. Maybe with more time I will try to use your entire plugin. I will atach here 2 videos with the bugs that I mentioned (IOS Mobile in Safari and Chrome) just to share the problem.
Thank you again dude!

Videos: https://drive.google.com/drive/folders/1dmBzPgZ91RSq58jCkLgGV9U1u_a99pcK?usp=sharing

@JayWii
Copy link

JayWii commented Dec 1, 2017

@capuski maybe you need FastClick.js. I guess。。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests