Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Window Title on Windows #3

Merged
merged 2 commits into from Jul 20, 2022
Merged

Added Window Title on Windows #3

merged 2 commits into from Jul 20, 2022

Conversation

gertdreyer
Copy link
Contributor

I have added functionality to get the window title on Windows. Unfortunately, I do not have a Linux or Mac machine set up to do the same for those.

I am not too up to date on the Rust best practices but L28 seems like a possible race condition to me as the window handle is retrieved again inside the self.get_position() call.

@dimusic
Copy link
Owner

dimusic commented Jul 20, 2022

Thanks!
I updated linux and macos apis to return an empty string for now, I'll try to implement it properly later.

Also the issue you brought up with repeated call to get the window handle looks like an actual bug. I'll fix it later or feel free to make another pull request.

@dimusic dimusic closed this Jul 20, 2022
@dimusic dimusic reopened this Jul 20, 2022
@dimusic dimusic merged commit 7a1f4d4 into dimusic:main Jul 20, 2022
@gertdreyer gertdreyer deleted the features/activeWindowTitle branch July 20, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants