Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background images data-src-small #172

Closed
mikeziri opened this issue Sep 17, 2018 · 1 comment
Closed

Background images data-src-small #172

mikeziri opened this issue Sep 17, 2018 · 1 comment

Comments

@mikeziri
Copy link

Having data-src-small alongside data-src doesn't seem to trigger different background-image (urls) based on window size.

Looking at the code I can clearly see it is not being used as it simply sets the background-image url with src.
would be excellent if you could add the logic used on to select the appropriate src.

I tried to understand how it is calculated but the handleSources simply sets the attributes, doesn't choose based on the window size.

ty, and keep up the great work.

@mikeziri
Copy link
Author

After further investigation, I found that I need to set the breakpoints (there aren't any defaults) and also, I must use a real mobile device or emulate in browser because window size is not taken into account, device size is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant