fix: don't accept extra fields inside the currency options on create #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to save and retrieve dineros to/from our storage layer we map them to a copycat money-type. However, on retrievals we noticed that internal fields were leaking into the currency objects like so:
... and upon further investigation one can pass anything into a dinero's currency object as long as the required subset of fields is met. This change makes the selection of fields as explicit as the base structure's (where
amount
,currency
andscale
are taken and everything else ignored).