[Bug]: Multiplied negative values increases amount

[milankyncl]

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

After multiplying negative numbers it adds an extra amount into the Dinero object.

const d = dinero({ amount: -200, currency: USD });    // { amount: 200 }  -> OK!
const m = multiply(d, 1);                             // { amount: -201 } -> not OK!

Happy to share further details.

Reproducible in the attached Code Sandbox.

Expected behavior

To be the same, but just in a negative value.

Steps to reproduce

https://codesandbox.io/s/fervent-violet-qkozxe?file=/main.js

Version

2.0.0-alpha.13

Environment

Node.js v14.18.0

Code of Conduct

• I agree to follow this project's Code of Conduct

[johnhooks]

@milankyncl I think I why this bug might be happening. The core function transformScale preforms a rounding operation in multiply. The logic was recently reworked in down. I'll add some tests and dive into it soon.

[johnhooks]

@milankyncl Looks like this issue has already been fixed in PR #711, hopefully we can get it merged soon.

[kdurek]

Hey, sadly same happens multiplying positive dinero by -1