Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

23 improve manager #34

Merged
merged 9 commits into from Apr 30, 2021
Merged

23 improve manager #34

merged 9 commits into from Apr 30, 2021

Conversation

dinghino
Copy link
Owner

Major changes

  • Added base classes for all components and manager Handlers
  • Added validation on manager components registration
  • Added manager handling for writers
  • Refactored some code in app and tests to handle the changes
  • Moved components registration in cli app for cleaner package code

@dinghino
update manager to track sources separetely
549ca65 
better handling and we could implement a method to ask for registered sources
@dinghino
refactor manager to return handlers as tuple
56ef841 
instead of returning the whole Handler
just return (fetcher, parser)

update app class and related tests
@dinghino
rename registered_handler to registered_handlers
6d9c7d3
@dinghino
fix typo
fa1f0f6
@dinghino
add writers to manager & refactor
ff2aacf 
update app class
add existing writers to manager in components __init__
update tests
@dinghino
move initial component registration in cli app
31aea82 
This allows a clean slate when importing the package
update tests accordingly

TODO: Note in readme for package usage
@dinghino
Add ComponentBase and class validation
8b50021 
All components derive now from ComponentBase
ComponentBase has `is_for` that MUST be implemented on final class
is_for is used to validate components when adding on manager

manager Handler classes now have a parent class with validation methods
@codecov
Copy link

codecov bot commented Apr 30, 2021 •
edited

Codecov Report

Merging #34 (6bdc4cc) into master (d95294a) will increase coverage by 0%.
The diff coverage is 99%.

❗ Current head 6bdc4cc differs from pull request most recent head 6f238fb. Consider uploading reports for the commit 6f238fb to get more accurate results

@@         Coverage Diff          @@
##           master   #34   +/-   ##
====================================
  Coverage      94%   94%           
====================================
  Files          23    24    +1     
  Lines         587   653   +66     
  Branches       66    63    -3     
====================================
+ Hits          552   619   +67     
  Misses         24    24           
+ Partials       11    10    -1

@dinghino dinghino merged commit 91d44d4 into master Apr 30, 2021
@dinghino dinghino mentioned this pull request Apr 30, 2021
Merged
@dinghino dinghino deleted the feature/23-improve-manager branch April 30, 2021 14:13
@dinghino dinghino linked an issue Apr 30, 2021 that may be closed by this pull request
Improve manager & component handling #23
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve manager & component handling
1 participant
@dinghino