Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model different to paper #2

Closed
dannyhung1128 opened this issue Dec 25, 2019 · 5 comments
Closed

Model different to paper #2

dannyhung1128 opened this issue Dec 25, 2019 · 5 comments

Comments

@dannyhung1128
Copy link

dannyhung1128 commented Dec 25, 2019

Hi - thank you for the good work,

I notice that your model in this repo is different from the one you presented in your paper, and that in README you mentioned one can achieve better performance by adding more D4LCN modules.

Which model is the one you used to produce the results in the paper? What's the difference in terms of performance?

Thanks

@dingmyu
Copy link
Owner

dingmyu commented Dec 25, 2019

Hi Danny,

What do you mean by the difference between the model and the paper?

The model in this repo is consistent with the paper and can produce the same results as the paper. In the experiment, we found that adding the D4LCN module to the first three blocks achieves the best results. And the D4LCN module after block2 is the most important, the module after block1 is the least important.

For convenience, we try to provide a time-saving model, which can be trained on 11GB GPUs in one day. In README, we provide a simplified version of the model. This model only uses a D4LCN module after block2, which also produces good performance. What we want to prove is that using only one D4LCN module can also bring significant improvements. The result of this simplified model is almost the same as that in the paper, you can download and have a try :)

Thanks

@dannyhung1128
Copy link
Author

dannyhung1128 commented Dec 25, 2019

Like you mentioned you use D4LCN 3 times but in your repo only 2 times.
This line was commented out https://github.com/dingmyu/D4LCN/blob/master/models/resnet_dilate.py#L148

@dannyhung1128
Copy link
Author

just curious, have you switched your depth input into 3d depth, which contains 3d depth points x, y, z?

@dingmyu
Copy link
Owner

dingmyu commented Dec 26, 2019

The model in this repo is consistent with the paper and can produce the same results as the paper. In the experiment, we found that adding the D4LCN module to the first three blocks achieves the best results. And the D4LCN module after block2 is the most important, the module after block1 is the least important.

For convenience, we try to provide a time-saving model, which can be trained on 11GB GPUs in one day.

Hi Danny,

As I said, the performance with and without D4LCN on block1 is similar.

Do you mean pseudo-LiDAR representations or x-y-z three channels? I didn't try pseudo-LiDAR because 3D processing should be more time-consuming than 2D. However, using three channels seems like a good idea if u want to try : )

Thanks.

@dingmyu
Copy link
Owner

dingmyu commented Dec 27, 2019

Feel free to reopen it if you have any further questions.

@dingmyu dingmyu closed this as completed Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants