[L5.1] config stops config:cache working

[xLink]

the api config currently has this:

    'auth' => [
        'basic' => function ($app) {
            return new Dingo\Api\Auth\Provider\Basic($app['auth']);
        }
    ],

the closure there will break the config:cache from working, is there anyway you can rework the code to avoid the closure being needed, was thinking something like:

    'auth' => [
        'basic' => 'Dingo\Api\Auth\Provider\Basic',
    ],

then the config:cache will work and and we can still use the speed boost :D

[tymondesigns]

This is an issue in a few libraries now (including my own)

tymondesigns/jwt-auth#147
https://github.com/lucadegasperi/oauth2-server-laravel/issues/323
efficiently/authority-controller#27

[xLink]

looks like there is a fix here: efficiently/authority-controller#27 (comment)

will try it when i get home and report back

[tymondesigns]

Yep SuperClosure can be used to serialize it.

[jasonlewis]

I'll look into simplifying the configuration as much as I can. I'm afraid it may mean configuring it in other places though, which is probably less than ideal.

[xLink]

i had a look locally, it worked without issue, so i created a pull request

[tomschlick]

Following your advice, my config looks like this

I get this error when hitting any artisan command / http endpoint afterwards

Anyone else seeing this?

[jasonlewis]

I've not used the serializer for config caching so can't give you any advice here.

I still need to look more into this issue. I guess for now if this isn't work don't cache your config. That or do your API related config in a bootstrapping file as everything can be configured on runtime.

Here's how you'd do authentication.

app('Dingo\Api\Auth\Auth')->extend('jwt', function ($app) {
    return new Dingo\Api\Auth\Provider\JWT($app['Tymon\JWTAuth\JWTAuth']);
});

The wiki covers the others.

[astroanu]

Laravel doesn't use closures in config anymore. you will need to pass a string. Any update on this ?

[jasonlewis]

Hm, I'll see what changes I can make.

I guess most of the more complex keys can be pulled out and simply be set from a provider.

[jasonlewis]

I've gone ahead and removed the ability to use closures and callables in a config file. Docs have been updated to demonstrate the alternative ways of configuring more complex aspects of the package.