Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dingo-store-mpu, dingo-net-netty] Use RocksDB checkpoint to implement backup mechanism and fix a FileReceiver bug. #449

Merged
merged 3 commits into from Nov 19, 2022

Conversation

ketor
Copy link
Contributor

@ketor ketor commented Nov 18, 2022

  1. Add checkpoint code in RocksStorage , also add unit-tests for new checkpoint code.
  2. Remove deprecated backup code.
  3. Remove all backup calls in RocksDB event listener.
  4. Fix FileReceiver bug, now call registerTagMessageListener in FileSender.

Best wishes to dingo maintainers!

And Dingo is an amazing database project!!!

@ketor ketor force-pushed the wip-use-rocksdb-checkpoint-new branch 2 times, most recently from 3268600 to 5849276 Compare November 18, 2022 14:34
RocksDB checkpoint is very fast, it is mainly base on filesystem hardlink, so we disable all backup operation in RocksDB
event listener callbacks. Now only execute checkpoint before full RocksDB transfer from leader node to follower node.

Signed-off-by: Ketor <d.ketor@gmail.com>
…age listener.

Register FILE_TRANSFER tag message listener in static code of FileSender.

Signed-off-by: Ketor <d.ketor@gmail.com>
Signed-off-by: Ketor <d.ketor@gmail.com>
@ketor ketor force-pushed the wip-use-rocksdb-checkpoint-new branch from 5849276 to ef38d5a Compare November 18, 2022 14:38
@ketor
Copy link
Contributor Author

ketor commented Nov 18, 2022

Fixed all checkstyle warnings of this pull request.

Please help review again.

Thanks!

@huzx0608

@astor-oss astor-oss merged commit 4a93592 into dingodb:develop Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants