Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build problems (with GTK 4.10?) #1479

Closed
jackhill opened this issue Sep 12, 2023 · 2 comments
Closed

Build problems (with GTK 4.10?) #1479

jackhill opened this issue Sep 12, 2023 · 2 comments

Comments

@jackhill
Copy link

Hi Dino,

I recently tried to build Dino from a Guix branch with some GTK and GNOME updates. In particular, GTK has been updated from 4.8.1 to 4.10.3. That results in the following errors during the build:

/tmp/guix-build-dino-0.4.3.drv-0/dino-0.4.3/main/src/ui/util/helper.vala:180.26-180.33: error: Argument 1: Cannot convert from `unowned uint8[]' to `unowned string'
  180 |         p.load_from_data(css.data);
      |                          ^~~~~~~~  
/tmp/guix-build-dino-0.4.3.drv-0/dino-0.4.3/main/src/ui/util/helper.vala:180.9-180.34: error: 1 missing arguments for `void Gtk.CssProvider.load_from_data (string, ssize_t)'
  180 |         p.load_from_data(css.data);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~ 

Let me know what additional information might be helpful. I've attached a gzipped full build log.

Best,
Jack

@mar-v-in
Copy link
Member

This is a bug in Vala 0.56.11/0.56.12 and was fixed in 0.56.13.

Upstream issue: https://gitlab.gnome.org/GNOME/vala/-/issues/1478

@jackhill
Copy link
Author

Indeed, updating Vala solved it. Thanks for the information, and sorry for the noise. I've submitted a patch to have Vala updated in Guix. I'll close this issue. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants