segfault when run with libsignal-protocol-c

[bowlofeggs]

Greetings!

I've been working on packaging dino for Fedora, and ideally I'd use a system provided libsignal-protocol-c instead of the bundled version.

I made a package for libsignal-protocol-c-2.3.2 (the latest release), but when I link dino against that package it segfaults if I send a contact an OMEMO encrypted message.

I see that dino's bundled version is a commit that is a few after the 2.3.0 release, so I guess it's possible that dino is not compatible with 2.3.2?

I can bundle this dependency in Fedora if need be, but I thought it would be worth reporting here. I may be able to just ship 2.3.0 in Fedora instead, though I'd prefer to use the newer version if possible.

[bowlofeggs]

I packaged libsignal-protocol-c-2.3.0 and the segfault went away, so I suppose there must be some incompatibility with the newer release of libsignal-protocol-c.

[mar-v-in]

@bowlofeggs this is because of signalapp/libsignal-protocol-c#112. OpenSUSE packages also already had this problem, their solution was to statically link the old version into dinos omemo plugin (which is already supported by our build script). Upstream seems to be not very sensible about third-parties using their library, so this seems for now to be the best thing possible. We might switch over to support 2.3.2 at some point or use a different library once a suitable one becomes available.

[bowlofeggs]

I wish the whole world would use semver :/

[mar-v-in]

We are using libsignal-protocol-c 2.3.2 since commit 7012023. Closing this now.

[bowlofeggs]

Whoah that was quick, thanks!