Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce error message verbosity - use warnings and only show if -debug used #116

Open
hansr opened this issue Jul 19, 2023 · 2 comments
Open

Comments

@hansr
Copy link
Member

hansr commented Jul 19, 2023

The "ERROR Couldn't get blockpeak" and "ERROR failed to submit ticket" are often because the CLI has succeeded and has closed connections, but some other thread is then throwing the error because the connections are closed.

hr@Hs-MacBook-Pro website_dev_2023 % diode time
INFO Diode Client version : v0.13.0 05 Aug 2022
INFO Client address : 0xb6a70432a8bbbcb9ce019c9a9c82fd0f651be121
INFO Fleet address : 0x6000000000000000000000000000000000000000
INFO Network is validated, last valid block: 5767264 0x000038672a09f5b38086d750ad626a45ed6d3dfadbe20bff43f2ca1554de4953
INFO Client name : harnewlaptop.diode
INFO Minimum Time : Wed Jul 19 09:33:25 PDT 2023 (1689784405)
INFO Maximum Time : Wed Jul 19 09:58:25 PDT 2023 (1689785905)
ERROR Couldn't getblockpeak: rpc call has been cancelled server=eu2.prenet.diode.io:41046
ERROR Couldn't download block header rpc call has been cancelled server=eu1.prenet.diode.io:41046
ERROR Couldn't getblockpeak: rpc call has been cancelled server=as2.prenet.diode.io:41046
ERROR failed to submit ticket: rpc call has been cancelled server=as2.prenet.diode.io:41046

@hansr
Copy link
Member Author

hansr commented Oct 20, 2023

Addition report from users of these errors despite successful connection(s):

image

@hansr hansr changed the title Too many error messages Reduce error message verbosity - use warnings and only show if -debug used Oct 20, 2023
@dominicletz
Copy link
Member

The "ERROR Couldn't get blockpeak" and "ERROR failed to submit ticket" are often because the CLI has succeeded and has closed connections, but some other thread is then throwing the error because the connections are closed.

hr@Hs-MacBook-Pro website_dev_2023 % diode time INFO Diode Client version : v0.13.0 05 Aug 2022 INFO Client address : 0xb6a70432a8bbbcb9ce019c9a9c82fd0f651be121 INFO Fleet address : 0x6000000000000000000000000000000000000000 INFO Network is validated, last valid block: 5767264 0x000038672a09f5b38086d750ad626a45ed6d3dfadbe20bff43f2ca1554de4953 INFO Client name : harnewlaptop.diode INFO Minimum Time : Wed Jul 19 09:33:25 PDT 2023 (1689784405) INFO Maximum Time : Wed Jul 19 09:58:25 PDT 2023 (1689785905) ERROR Couldn't getblockpeak: rpc call has been cancelled server=eu2.prenet.diode.io:41046 ERROR Couldn't download block header rpc call has been cancelled server=eu1.prenet.diode.io:41046 ERROR Couldn't getblockpeak: rpc call has been cancelled server=as2.prenet.diode.io:41046 ERROR failed to submit ticket: rpc call has been cancelled server=as2.prenet.diode.io:41046

We have reduced error messages quite in a bit in v0.13.4 -- addressing the first comment. The second comment though is still valid. We could reduce these errors to warnings though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants