Pin scipy version for bots that need statsmodels. #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to breaking changes in the scipy API that will be fixed on an eventual release of statsmodels. For now, let's pin this and unpin when a new release of scipy comes along.
Codecov Report
@@ Coverage Diff @@
## master #1855 +/- ##
=========================================
Coverage ? 84.31%
=========================================
Files ? 117
Lines ? 14234
Branches ? 2251
=========================================
Hits ? 12001
Misses ? 1716
Partials ? 517 |
|
It looks like the bots are happy, but is there a more elegant way to implement this? |
This was referenced Jun 13, 2019
|
No Idea yet but I propose to merge this and we can create an issue to improve our Travis design. What do you think? |
|
Sounds good. I also want to experiment a bit with CircleCI, so I can do that on a separate PR. But yes: feel free to merge this one. |
|
Thank you @arokem for this! |
This was referenced Jun 18, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to breaking changes in the scipy API that will be fixed on an eventual release of statsmodels. For now, let's pin this and unpin when a new release of scipy comes along.
Should help deal with this breakage: https://travis-ci.org/nipy/dipy/jobs/542426220#L6092