Use logging instead of print statements

[arokem]

Also removing "from future" imports along the way.

[skoudoro]

Overall this PR looks good to me. I see a WIP on your title, are there other files that you want to update?

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@22b015e). Click here to learn what that means.
The diff coverage is 79.16%.

@@            Coverage Diff            @@
##             master    #1862   +/-   ##
=========================================
  Coverage          ?   91.12%           
=========================================
  Files             ?      243           
  Lines             ?    31252           
  Branches          ?     3273           
=========================================
  Hits              ?    28478           
  Misses            ?     2041           
  Partials          ?      733

Impacted Files	Coverage Δ
dipy/core/tests/test_sphere.py	65.04% <ø> (ø)
dipy/core/rng.py	46.34% <ø> (ø)
dipy/align/tests/test_imwarp.py	99.22% <ø> (ø)
dipy/core/graph.py	73.49% <ø> (ø)
dipy/denoise/tests/test_noise_estimate.py	100% <ø> (ø)
dipy/data/__init__.py	81.69% <ø> (ø)
dipy/core/sphere.py	93.87% <ø> (ø)
dipy/core/onetime.py	89.47% <ø> (ø)
dipy/core/sphere_stats.py	58.33% <ø> (ø)
dipy/core/ndindex.py	76.92% <ø> (ø)
... and 7 more

[skoudoro]

Do we really want to keep this function? Since you are using logging module, you should delete it.

[arokem]

It's useful as shorthand. I just pushed a clarification of the docstring.

[arokem]

Now also rebased.

[pep8speaks]

Hello @arokem, Thank you for updating !

• In the file dipy/segment/bundles.py:

Line 127:81: E501 line too long (82 > 80 characters)

Comment last updated at 2019-12-19 17:34:36 UTC

[arokem]

I'm also taking the opportunity to remove verbose settings, because I believe this should be set by the logging level. Would this break something else?

[skoudoro]

I think we should keep verbose. We just need to improve it and do like the registration module. Look at dipy.align.imwarp

[skoudoro]

Hi @arokem, What is your status on this PR? it looks close to being done!

[arokem]

Just rebased. IIUC, the main thing that needs to be done is reinstating verbose setting?

[skoudoro]

Yes, I think so

[arokem]

OK. I believe that I have restored the verbose flag everywhere we previously had it. I still think that this is something that is best handled by having the users set their logging levels, but we can also do that later if y'all end up agreeing with me.

[arokem]

I believe that this ready for a re-review. Codecov is just being dumb.

[arokem]

@arokem will look into nicer printing options for logging

[arokem]

Some more thoughts about logging: https://fangpenlin.com/posts/2012/08/26/good-logging-practice-in-python/

[skoudoro]

Is there anything you want to add? I forgot what we said during the last online meeting concerning this PR but it looks ready to be merged for me. Maybe, the logging "design/string format" can be done on a new PR. What do you think?

[arokem]

Ready on my end. @Garyfallidis : have you had a chance to think about this more?

[skoudoro]

can you rebase this one or resolve the conflict @arokem?

[arokem]

Rebased!

[skoudoro]

Thank you @arokem! Any other comments? will merge it by the end of the week

[Garyfallidis]

Hello @arokem. Sorry can you rebase this one more time? Will look into merging the following days.

[arokem]

All set.

…

On Thu, Dec 19, 2019 at 9:19 AM Eleftherios Garyfallidis < ***@***.***> wrote: Hello @arokem <https://github.com/arokem>. Sorry can you rebase this one more time? Will look into merging the following days. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1862>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA46NVELKR5OX2LQSMWZILQZOULTANCNFSM4HZJHFCQ> .