Doc generation under Windows #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @skoudoro, Thank you for updating !
Comment last updated at 2019-07-24 19:24:26 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1915 +/- ##
==========================================
+ Coverage 85.42% 85.44% +0.01%
==========================================
Files 119 119
Lines 14296 14296
Branches 2242 2242
==========================================
+ Hits 12213 12215 +2
+ Misses 1575 1574 -1
+ Partials 508 507 -1
|
skoudoro
changed the title
|
Ok, this PR is done and ready to be reviewed! |
1 similar comment
|
Ok, this PR is done and ready to be reviewed! |
|
Can you restart Appveyor @arokem? Thank you? |
* shebang modification * pep8 correction The goal of this change is to avoid crash on windows
* update python call and working directory
… of this character.
skoudoro
force-pushed
the
windows-doc-gen
branch
from
8ee4430
to
94201fe
Compare
arokem
reviewed
Jul 24, 2019
dipy/reconst/dti.py
Outdated
| @@ -720,7 +720,7 @@ def __init__(self, gtab, fit_method="WLS", return_S0_hat=False, *args, | |||
| is advisable to keep an eye on memory consumption as this value is | |||
| increased. | |||
|
|
|||
| Example : In :func:`iter_fit_tensor` we have a default step value of | |||
| e.g.: In :func:`iter_fit_tensor` we have a default step value of | |||
There was a problem hiding this comment.
The phrase "e.g." should always be followed by a comma. And in this case, capitalized, as it's in the beginning of a sentence.
Co-Authored-By: Ariel Rokem <arokem@gmail.com>
Yes, it triggers a warning. As soon as it differs from |
|
OK. Off we go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to permit the doc generation under windows.
I use the opportunity to fix many warning during the doc generation like: