Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken link of devel #1971

Merged
merged 3 commits into from Sep 23, 2019
Merged

Conversation

RicciWoo
Copy link
Contributor

Fix the broken link under the subtitle "The development process" of the file "CONTRIBUTING.md".
It looks like after we released version 1.0.0, the route of the website change a little bit. This might cause other broken links. And also, there might be a better way to fix this. Discussion and advice are welcoming.

Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching that @RicciWoo! Below a small comment. I will merge it as soon as you update this change.

CONTRIBUTING.md Outdated
@@ -18,7 +18,7 @@ conversation about the issue, by typing into the text box in the issue page.

## The development process

Please refer to the [development section](http://dipy.org/devel/index.html)
Please refer to the [development section](https://dipy.org/documentation/1.0.0./devel/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use: https://dipy.org/documentation/latest/devel/

@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #1971 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1971   +/-   ##
======================================
  Coverage    83.8%   83.8%           
======================================
  Files         118     118           
  Lines       15043   15043           
  Branches     2377    2377           
======================================
  Hits        12607   12607           
  Misses       1875    1875           
  Partials      561     561

@skoudoro skoudoro merged commit 722eef5 into dipy:master Sep 23, 2019
@skoudoro
Copy link
Member

Thanks @RicciWoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants