Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: Fix inconsistent function parameters #2295

Merged
merged 1 commit into from Nov 17, 2020

Conversation

areeshatariq
Copy link
Contributor

Some parameters were inconsistent e.g. static_img_files and static_image_files. They are made consistent to avoid any confusion.

Some paramters were inconsistent e.g. static_img_files
and static_image_files. They are fixed.
@jhlegarreta jhlegarreta self-requested a review November 16, 2020 22:50
Copy link
Contributor

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for doing this.

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #2295 (65ed2ec) into master (6c54e89) will decrease coverage by 1.99%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2295      +/-   ##
==========================================
- Coverage   91.38%   89.39%   -2.00%     
==========================================
  Files         254      254              
  Lines       33850    33850              
  Branches     3569     3569              
==========================================
- Hits        30933    30259     -674     
- Misses       2111     2815     +704     
+ Partials      806      776      -30     
Impacted Files Coverage Δ
dipy/workflows/align.py 88.12% <100.00%> (ø)
dipy/workflows/tests/test_viz.py 23.80% <0.00%> (-73.02%) ⬇️
dipy/viz/app.py 4.40% <0.00%> (-72.87%) ⬇️
dipy/viz/tests/test_apps.py 24.56% <0.00%> (-70.18%) ⬇️
dipy/viz/panel.py 3.41% <0.00%> (-60.76%) ⬇️
dipy/io/vtk.py 28.57% <0.00%> (-60.72%) ⬇️
dipy/workflows/viz.py 14.28% <0.00%> (-48.58%) ⬇️
dipy/viz/__init__.py 35.00% <0.00%> (-30.00%) ⬇️
dipy/io/tests/test_streamline.py 89.65% <0.00%> (-8.05%) ⬇️
dipy/utils/optpkg.py 73.91% <0.00%> (-4.35%) ⬇️
... and 6 more

@jhlegarreta
Copy link
Contributor

jhlegarreta commented Nov 17, 2020

The failure reported by Travis CI is unrelated. Merging.

@jhlegarreta jhlegarreta merged commit 20fae8e into dipy:master Nov 17, 2020
@skoudoro skoudoro added this to the 1.4 milestone Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants