Small correction on KFA #2405
Small correction on KFA #2405
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2405 +/- ##
==========================================
- Coverage 85.26% 85.25% -0.02%
==========================================
Files 125 125
Lines 16581 16581
Branches 2686 2685 -1
==========================================
- Hits 14138 14136 -2
Misses 1759 1759
- Partials 684 686 +2
|
There was a problem hiding this comment.
Hi @RafaelNH,
Thank you for the update. it seems your test is failing on our CI's:
> assert_almost_equal(dkiF.kfa, 0)
E AssertionError:
E Arrays are not almost equal to 7 decimals
E
E Mismatched elements: 1 / 1 (100%)
E Max absolute difference: 0.8582412541188063
E Max relative difference: inf
E x: array(0.8582412541188063)
E y: array(0)more information here
Can you have a quick look? Thanks!
|
Hi @RafaelNH, this a just a small ping concerning my question/comment above. |
|
Hi @skoudoro! Thanks for pointing that the test was failing! At least, it was ensuring that the added test detected that issue. This test failure was related to KFA estimates for null kurtosis zeros (in which MKT = 0). MKT was supposed to be zero on the added test, but due to numerical precision is was having a small magnitude. It didn't fail on my pc, because my pc computed a negative residual MKT values, while in the CI tests MKT was giving a small positive residual value. To fix the issue, I am now using a small tolerance to detect null kurtosis tensors (i.e. MKT < tol). |
|
Looks like the remaining failures are the ones that will be fixed through #2407, so I think this is good to go. |
|
I agree, good to go. Thank you @RafaelNH for this fix! merging |
This should be a small correction on KFA definition - it has to be zero if the kurtosis tensor is null.