Fixes the default option in the command line for Patch2Self 'ridge' -> 'ols' #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoudoro
reviewed
Jul 6, 2021
There was a problem hiding this comment.
Hi @ShreyasFadnavis,
LGTM! Do not forget to update the docstring and then, we can merge it
Done! Thanks :) |
Codecov Report
@@ Coverage Diff @@
## master #2419 +/- ##
=======================================
Coverage 85.38% 85.38%
=======================================
Files 125 125
Lines 16585 16585
Branches 2685 2685
=======================================
Hits 14161 14161
Misses 1744 1744
Partials 680 680
|
All green now! @skoudoro GTG? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description as above!