STYLE: Fix miscellaneous Python warnings #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jhlegarreta
commented
May 28, 2022
•
jhlegarreta
commented
- DOC: Use triple double-quoted strings in docstrings
- STYLE: Avoid array-like mutable default argument values
- STYLE: Avoid re-declaring variables in nested for loops
- STYLE: Replace function call with set literal
- STYLE: Simplify chained comparisons
- STYLE: Avoid shadowing built-in names
Conform to PEP 257: use triple double-quoted strings in docstrings. Fixes: ``` Triple double-quoted strings should be used for docstrings. ```
Avoid array-like mutable default argument values. Fixes: ``` Default argument value is mutable ``` Change the docstrings accordingly.
Remove redundant parentheses. Fixes: ``` Remove redundant parentheses ```
Avoid re-declaring variables in nested `for` loops. Fixes e.g.: ``` Variable 'dim' is already declared in 'for' loop or 'with' statement above ```
Replace function call with set literal. Fixes: ``` Function call can be replaced with set literal ```
|
Hello @jhlegarreta, Thank you for updating ! Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated at 2022-05-29 19:17:47 UTC |
jhlegarreta
force-pushed
the
FixMiscPythonWarnings2
branch
2 times, most recently
from
8606dcc
to
ac4b478
Compare
jhlegarreta
commented
May 29, 2022
| @@ -679,7 +679,7 @@ def l_shore(radial_order): | |||
|
|
|||
|
|
|||
| def n_shore(radial_order): | |||
| "Returns the angular regularisation matrix for SHORE basis" | |||
| """Returns the angular regularisation matrix for SHORE basis""" | |||
There was a problem hiding this comment.
BTW, the l_shore, and n_shore methods are exactly the same. I have not found the equations in the paper. If they should be the same, then only one method should exist.
There was a problem hiding this comment.
Maybe @maurozucchelli has an answer concerning l_shore and n_shore?
Codecov Report
@@ Coverage Diff @@
## master #2606 +/- ##
==========================================
- Coverage 84.27% 84.26% -0.01%
==========================================
Files 130 130
Lines 17914 17916 +2
Branches 3051 3051
==========================================
Hits 15097 15097
- Misses 2102 2104 +2
Partials 715 715
|
|
Failing build is |
skoudoro
reviewed
May 29, 2022
There was a problem hiding this comment.
Hi @jhlegarreta,
Thank you for this PR. It is almost ready to go. See below for some comments.
| @@ -679,7 +679,7 @@ def l_shore(radial_order): | |||
|
|
|||
|
|
|||
| def n_shore(radial_order): | |||
| "Returns the angular regularisation matrix for SHORE basis" | |||
| """Returns the angular regularisation matrix for SHORE basis""" | |||
There was a problem hiding this comment.
Maybe @maurozucchelli has an answer concerning l_shore and n_shore?
jhlegarreta
force-pushed
the
FixMiscPythonWarnings2
branch
from
ac4b478
to
4e9cab5
Compare
|
Same failure as for the previous commit, |
Simplify chained comparisons. Fixes: ``` Too complex chained comparisons. ```
Rename method parameters and local variables to avoid shadowing built-in names. Fixes e.g. ``` Shadows built-in name 'bytes' ```
jhlegarreta
force-pushed
the
FixMiscPythonWarnings2
branch
from
4e9cab5
to
cc31f08
Compare
|
LGTM ! Thank you @jhlegarreta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.