-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patch_radius
parameter to Patch2Self denoise workflow
#2792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you for this @pcamach2!
it is missing the part to check if it is a list of int
or just a int
. You can look at this example:
dipy/dipy/workflows/denoise.py
Line 310 in 976217e
if isinstance(patch_radius, list) and len(patch_radius) == 1: |
Also, it would be great if you could update the test :
dipy/dipy/workflows/tests/test_denoise.py
Line 43 in 976217e
def test_patch2self_flow(): |
Thank you!
Addresses enhancement review from @skoudoro in dipy#2792 (review)
Thank you for your review, @skoudoro! Please let me know if anything else needs adjusting for this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Waiting for the CI's to finish, then I will go ahead and merge it.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2792 +/- ##
=======================================
Coverage 81.48% 81.49%
=======================================
Files 143 143
Lines 20049 20051 +2
Branches 3191 3192 +1
=======================================
+ Hits 16337 16340 +3
+ Misses 2906 2904 -2
- Partials 806 807 +1
|
ok, all green, merging. Thanks again @pcamach2 ! |
Addresses #2791