Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dependencies mininal version #2795

Merged
merged 2 commits into from
May 2, 2023
Merged

Conversation

skoudoro
Copy link
Member

@skoudoro skoudoro commented May 1, 2023

Small PR to bump our minimal version.

numpy 1.14.5 -> 1.22.4
scipy 1.1 -> 1.8.1
nibabel 3.0.0 -> 4.0.0
h5py 2.8.0 -> 3.7.0
fury 0.8 -> 0.9.0

python_requires 3.6 -> 3.8

Note: This will give us access to typing module which we should start to do.

@arokem
Copy link
Contributor

arokem commented May 1, 2023

I think that we need to bump this up to 3.8:

https://github.com/dipy/dipy/blob/master/setup.py#L58

IIUC, we should do that anyway, unrelated to this PR, but may as well do that here.

@skoudoro
Copy link
Member Author

skoudoro commented May 1, 2023

Good catch, thank you! I just updated that

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #2795 (f035a0b) into master (1f5f7e2) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2795   +/-   ##
=======================================
  Coverage   81.49%   81.49%           
=======================================
  Files         143      143           
  Lines       20051    20051           
  Branches     3192     3192           
=======================================
  Hits        16340    16340           
  Misses       2904     2904           
  Partials      807      807           
Impacted Files Coverage Δ
dipy/info.py 100.00% <100.00%> (ø)

@Garyfallidis Garyfallidis merged commit 287233d into dipy:master May 2, 2023
27 checks passed
@skoudoro skoudoro deleted the update-version branch May 2, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants