Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix error in conda jobs #2890

Closed
wants to merge 1 commit into from

Conversation

DimitriPapadopoulos
Copy link
Contributor

AttributeError: type object 'spmatrix' has no attribute 'div'. Did you mean: 'dir'?

OpenBB-finance/OpenBBTerminal#5208

AttributeError: type object 'spmatrix' has no attribute '__div__'. Did you mean: '__dir__'?

OpenBB-finance/OpenBBTerminal#5208
@DimitriPapadopoulos DimitriPapadopoulos changed the title CI: Attempt to fix error in conda jobs Attempt to fix error in conda jobs Sep 14, 2023
Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DimitriPapadopoulos,

Thank you for this attempt. See below my comment.

@@ -1,8 +1,8 @@
# Check against .travis.yml file and dipy/info.py
cython>=0.29.24, !=0.29.29
numpy>=1.22.4
scipy>=1.8.1
scipy=1.10.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DimitriPapadopoulos,

We do not want to pin scipy in requirement.txt. It should be flexible.

However, it is ok to pin scipy or numpy in our github workflows. look at this file.

I suppose the issue is coming from cvxpy version on conda. cvxpy version on Pypi is 1.3.2 and accept new version of numpy/scipy.cvxpy version on our conda CI is 1.2.2 for whatever reason. So either, we need to find a way to update this version OR pin numpy/scipy OR make sure to use conda-forge which have the right version (1.3.2)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just a test, not a real solution. Unfortunately, it doesn't work, either because pinning down scipy here doesn't work, or because the error is different (unrelated to the version of scipy in cvxpy).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it doesn't work, either because pinning down scipy here doesn't work

yes, as you can see here, scipy version is 1.11.1. You need to pin it on the github worflows file (see my comment above).

You can also see [here](Unfortunately, it doesn't work, either because pinning down scipy here doesn't work) that we do not use the requirements.txt for this CI matrix.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2890 (ae5b103) into master (bccd6c5) will decrease coverage by 0.02%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2890      +/-   ##
==========================================
- Coverage   81.41%   81.39%   -0.02%     
==========================================
  Files         145      145              
  Lines       20147    20147              
  Branches     3217     3217              
==========================================
- Hits        16402    16398       -4     
- Misses       2929     2932       +3     
- Partials      816      817       +1     

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants