Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Pin scipy for the conda failing CI's #2906

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Conversation

skoudoro
Copy link
Member

All in the Title.

Our Conda CI's are failing due to cvxpy version we have to pin scipy.

Supersed #2890

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2906 (9bbdda0) into master (f30d96d) will increase coverage by 0.18%.
Report is 59 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2906      +/-   ##
==========================================
+ Coverage   81.43%   81.61%   +0.18%     
==========================================
  Files         145      146       +1     
  Lines       20132    20363     +231     
  Branches     3214     3224      +10     
==========================================
+ Hits        16394    16619     +225     
- Misses       2922     2924       +2     
- Partials      816      820       +4     
Files Coverage Δ
dipy/reconst/dti.py 92.57% <100.00%> (+0.01%) ⬆️

... and 5 files with indirect coverage changes

@skoudoro skoudoro mentioned this pull request Sep 26, 2023
41 tasks
@skoudoro
Copy link
Member Author

ok, this is strange, all the dependencies are the same as https://github.com/dipy/dipy/actions/runs/5747080622/job/15577531014#step:6:59 which should be all greens but one CI's matrix is still failing.

still investigating... and if I do not find the reason, I will handle this error:

FAILED reconst/tests/test_dti.py::test_restore - numpy.linalg.LinAlgError: Eigenvalues did not converge

@skoudoro
Copy link
Member Author

Yeah! All green, this is ready to go @arokem. Feel free to check and merge it when you can. Thanks

@arokem
Copy link
Contributor

arokem commented Sep 29, 2023

Nice work!

@arokem arokem merged commit 7a82b59 into dipy:master Sep 29, 2023
27 checks passed
@skoudoro skoudoro deleted the fix-conda-jobs branch September 29, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants