RF - BootDirectionGetter

[gabknight]

This PR prepares PmfGen for cython optimization.

• Move bootPmfGen functionalities from dipy.direction.pmf to dipy.direction.bootstrap_direction_getter.pyx
• Change BootDirectionGetter parent class from PmfGenDirectionGetter to DirectionGetter
• Remove bootPmfGen class from dipy.direction.pmf
• Update tests

There are no noticeable performance impacts.

[pep8speaks]

Hello @gabknight, Thank you for updating !

• In the file dipy/direction/tests/test_bootstrap_direction_getter.py:

Line 235:5: E303 too many blank lines (2)
Line 247:1: W391 blank line at end of file

Comment last updated at 2023-10-20 20:05:41 UTC

[codecov]

Codecov Report

Merging #2947 (b278fb4) into master (3ad9ec1) will increase coverage by 0.01%.
Report is 97 commits behind head on master.
The diff coverage is 80.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2947      +/-   ##
==========================================
+ Coverage   81.77%   81.79%   +0.01%     
==========================================
  Files         146      146              
  Lines       20401    20401              
  Branches     3238     3238              
==========================================
+ Hits        16682    16686       +4     
+ Misses       2901     2898       -3     
+ Partials      818      817       -1     

Files	Coverage Δ
dipy/data/fetcher.py	40.25% <ø> (ø)
dipy/info.py	100.00% <100.00%> (ø)
dipy/io/stateful_tractogram.py	76.96% <100.00%> (ø)
dipy/reconst/dti.py	92.57% <0.00%> (ø)
dipy/tracking/local_tracking.py	94.44% <96.29%> (ø)
dipy/io/utils.py	88.83% <90.00%> (ø)
dipy/io/streamline.py	84.92% <75.00%> (ø)
dipy/align/imwarp.py	95.60% <37.50%> (ø)

... and 1 file with indirect coverage changes

[skoudoro]

Great! thank you for refactoring this! I like the simplification and the gain of speed.

it looks good to me for now. Can you check that we do not break any examples ?

Thank you

[gabknight]

It did break the example! The data array was missing a dtype check/transformation to float. I also added an optional b_tol parameter for more control.

If the tests are successful, all good on my side.

[skoudoro]

Thank you for this work @gabknight , merging