TEST: Filter legacy SH bases warnings in bootstrap direction getter test #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2958 +/- ##
==========================================
- Coverage 81.78% 81.77% -0.02%
==========================================
Files 146 146
Lines 20410 20410
Branches 3240 3240
==========================================
- Hits 16693 16690 -3
- Misses 2898 2901 +3
Partials 819 819 |
|
Build failures are unrelated: Seem to have been appearing after today, maybe PR #2929 has something to do with this (?). |
jhlegarreta
force-pushed
the
FilterSHBasisWarningsInBootDGTest
branch
2 times, most recently
from
a34c110
to
5123c34
Compare
Filter legacy SH bases warnings in bootstrap direction getter test.
Warnings are already being tested, and there is no further need to
ensure that these warnings are raised.
Filtering them avoids having them printed in the standard output, and
thus, unnecessary clutter.
Fixes:
```
direction/tests/test_bootstrap_direction_getter.py::test_bdg_get_direction
/home/runner/work/dipy/dipy/venv/lib/python3.11/site-packages/dipy/reconst/shm.py:351:
PendingDeprecationWarning:
The legacy descoteaux07 SH basis uses absolute values for negative harmonic degrees.
It is outdated and will be deprecated in a future DIPY release.
Consider using the new descoteaux07 basis by setting the `legacy` parameter to `False`.
warn(descoteaux07_legacy_msg, category=PendingDeprecationWarning)
```
Raised for example at:
https://github.com/dipy/dipy/actions/runs/6657261609/job/18091595226?pr=2941#step:9:4028
jhlegarreta
force-pushed
the
FilterSHBasisWarningsInBootDGTest
branch
from
5123c34
to
8204e2f
Compare
|
All targeted warnings are gone. A set of unrelated warnings have emerged after PR #2947 merge: |
|
thank you @jhlegarreta for this, looks good, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter legacy SH bases warnings in bootstrap direction getter test. Warnings are already being tested, and there is no further need to ensure that these warnings are raised.
Filtering them avoids having them printed in the standard output, and thus, unnecessary clutter.
Fixes:
Raised for example at:
https://github.com/dipy/dipy/actions/runs/6657261609/job/18091595226?pr=2941#step:9:4028