STYLE: Fix boolean variable negation warnings #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix boolean variable negation warnings: use the `not` operator instead
of the `~` opertor.
Fixes:
```
reconst/tests/test_csdeconv.py::test_odfdeconv
reconst/tests/test_csdeconv.py::test_odf_sh_to_sharp
reconst/tests/test_csdeconv.py::test_r2_term_odf_sharp
dipy/venv/lib/python3.12/site-packages/dipy/reconst/csdeconv.py:768:
DeprecationWarning: Bitwise inversion '~' on bool is deprecated.
This returns the bitwise inversion of the underlying int object and is
usually not what you expect from negating a bool. Use the 'not'
operator for boolean negation or ~int(x) if you really want the bitwise
inversion of the underlying int.
if ~r2_term:
```
and
```
tracking/streamline.py: 9 warnings
tracking/tests/test_streamline.py: 18 warnings
dipy/venv/lib/python3.12/site-packages/dipy/tracking/streamline.py:327:
DeprecationWarning: Bitwise inversion '~' on bool is deprecated.
This returns the bitwise inversion of the underlying int object and is
usually not what you expect from negating a bool. Use the 'not'
operator for boolean negation or ~int(x) if you really want the bitwise
inversion of the underlying int.
if include & ~exclude:
```
raised for example at:
https://github.com/dipy/dipy/actions/runs/7024094921/job/19112083400?pr=2981#step:9:4599
https://github.com/dipy/dipy/actions/runs/7024094921/job/19112083400?pr=2981#step:9:4621
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2983 +/- ##
=======================================
Coverage 81.71% 81.72%
=======================================
Files 147 147
Lines 20484 20569 +85
Branches 3277 3279 +2
=======================================
+ Hits 16739 16809 +70
- Misses 2913 2932 +19
+ Partials 832 828 -4
|
|
Great! thank you @jhlegarreta, merging |
|
Down to 192 warnings: at https://github.com/dipy/dipy/actions/runs/7039694223/job/19159201183#step:9:4562 from 226 warnings: at https://github.com/dipy/dipy/actions/runs/7024094921/job/19112083400?pr=2981#step:9:4635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix boolean variable negation warnings: use the
notoperator instead of the~opertor.Fixes:
and
raised for example at:
https://github.com/dipy/dipy/actions/runs/7024094921/job/19112083400?pr=2981#step:9:4599 https://github.com/dipy/dipy/actions/runs/7024094921/job/19112083400?pr=2981#step:9:4621