Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTN: fix byte swap ordering for numpy 2.0 #2991

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

skoudoro
Copy link
Member

@skoudoro skoudoro commented Dec 5, 2023

Related to #2979

This PR fix the byte swapping issue for Numpy 2.0. More information : https://numpy.org/devdocs/user/byteswapping.html

Fixes :

FAILED dipy/utils/tests/test_arrfuncs.py::test_as_native - AttributeError: `newbyteorder` was removed from the ndarray class in NumPy 2.0. Use `arr.view(arr.dtype.newbyteorder(order))` instead.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #2991 (27c8d55) into master (8670d56) will decrease coverage by 0.01%.
Report is 9 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2991      +/-   ##
==========================================
- Coverage   81.72%   81.71%   -0.01%     
==========================================
  Files         147      147              
  Lines       20569    20568       -1     
  Branches     3279     3279              
==========================================
- Hits        16809    16808       -1     
  Misses       2932     2932              
  Partials      828      828              
Files Coverage Δ
dipy/align/streamwarp.py 77.41% <ø> (ø)
dipy/core/gradients.py 87.04% <ø> (-0.04%) ⬇️
dipy/reconst/shm.py 93.50% <ø> (ø)
dipy/stats/analysis.py 92.30% <ø> (ø)
dipy/testing/decorators.py 76.59% <100.00%> (ø)
dipy/utils/arrfuncs.py 100.00% <100.00%> (ø)

@skoudoro
Copy link
Member Author

skoudoro commented Dec 6, 2023

Does anyone as a comment concerning this PR ? this is ready to go. @arokem ?

@Garyfallidis Garyfallidis merged commit fe43a47 into dipy:master Dec 6, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants