Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Define minimum version for some optional packages #3007

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

skoudoro
Copy link
Member

This PR:

  • Adds minimum version for cvxpy = 1.4.1
  • Adds minimum version for fury = 0.9.0
  • Adds minimum version for statsmodels = 0.14.0
  • Clean some import

it should helps #2999 and, in general, improve optional dependencies management.

- min version fury = 0.9.0
- min version statsmodels = 0.14.0
-clean some important
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #3007 (759b600) into master (4bcee65) will increase coverage by 0.24%.
The diff coverage is 86.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3007      +/-   ##
==========================================
+ Coverage   81.85%   82.10%   +0.24%     
==========================================
  Files         146      146              
  Lines       20512    20429      -83     
  Branches     3284     3254      -30     
==========================================
- Hits        16791    16773      -18     
+ Misses       2887     2849      -38     
+ Partials      834      807      -27     
Files Coverage Δ
dipy/denoise/gibbs.py 100.00% <100.00%> (+2.60%) ⬆️
dipy/io/vtk.py 85.71% <100.00%> (ø)
dipy/nn/cnn_1d_denoising.py 71.87% <100.00%> (+1.72%) ⬆️
dipy/nn/evac.py 83.13% <100.00%> (+0.65%) ⬆️
dipy/nn/histo_resdnn.py 86.20% <100.00%> (+1.76%) ⬆️
dipy/nn/model.py 96.00% <100.00%> (+5.25%) ⬆️
dipy/nn/synb0.py 54.02% <100.00%> (+0.29%) ⬆️
dipy/reconst/ivim.py 96.00% <100.00%> (+0.82%) ⬆️
dipy/reconst/mcsd.py 88.57% <100.00%> (+2.46%) ⬆️
dipy/stats/analysis.py 92.00% <ø> (-0.11%) ⬇️
... and 18 more

... and 1 file with indirect coverage changes

@Garyfallidis Garyfallidis merged commit d589cfd into dipy:master Dec 12, 2023
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants